Skip to content

Revert "Otel metrics source http service (#6604)"#6656

Merged
graytaylor0 merged 1 commit into
opensearch-project:mainfrom
graytaylor0:Docdbfix
Mar 19, 2026
Merged

Revert "Otel metrics source http service (#6604)"#6656
graytaylor0 merged 1 commit into
opensearch-project:mainfrom
graytaylor0:Docdbfix

Conversation

@graytaylor0

@graytaylor0 graytaylor0 commented Mar 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This reverts commit bb61dbe.

Description

This change (#6604) leads to an error in the otel metrics source on startup

2026-03-19T15:08:07.168 [metrics-pipeline-sink-worker-2-thread-1] ERROR org.opensearch.dataprepper.core.pipeline.common.PipelineThreadPoolExecutor - Pipeline [metrics-pipeline] process worker encountered a fatal exception, cannot proceed further
java.util.concurrent.ExecutionException: java.lang.IllegalArgumentException: PluginSetting.pipelineName must not be null
	at java.base/java.util.concurrent.FutureTask.report(FutureTask.java:122)
	at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:191)
	at org.opensearch.dataprepper.core.pipeline.common.PipelineThreadPoolExecutor.afterExecute(PipelineThreadPoolExecutor.java:75)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1137)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:840)
Caused by: java.lang.IllegalArgumentException: PluginSetting.pipelineName must not be null
	at org.opensearch.dataprepper.metrics.PluginMetrics.fromPluginSetting(PluginMetrics.java:32)
	at org.opensearch.dataprepper.metrics.PluginMetrics.fromPluginSetting(PluginMetrics.java:38)
	at org.opensearch.dataprepper.plugin.ComponentPluginArgumentsContext.lambda$new$2(ComponentPluginArgumentsContext.java:50)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:992)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:575)
	at java.base/java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:260)
	at java.base/java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:616)
	at java.base/java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:622)
	at org.opensearch.dataprepper.plugin.ComponentPluginArgumentsContext.createArguments(ComponentPluginArgumentsContext.java:87)
	at org.opensearch.dataprepper.plugin.PluginCreator.newPluginInstance(PluginCreator.java:46)
	at org.opensearch.dataprepper.plugin.DefaultPluginFactory.loadPlugin(DefaultPluginFactory.java:80)
	at org.opensearch.dataprepper.plugins.source.otelmetrics.OTelMetricsSource.createHttpAuthenticationProvider(OTelMetricsSource.java:224)
	at org.opensearch.dataprepper.plugins.source.otelmetrics.OTelMetricsSource.createHttpAuthentication(OTelMetricsSource.java:218)
	at org.opensearch.dataprepper.plugins.source.otelmetrics.OTelMetricsSource.configureAuthentication(OTelMetricsSource.java:194)
	at org.opensearch.dataprepper.plugins.source.otelmetrics.OTelMetricsSource.start(OTelMetricsSource.java:132)
	at org.opensearch.dataprepper.core.pipeline.Pipeline.startSourceAndProcessors(Pipeline.java:251)
	at org.opensearch.dataprepper.core.pipeline.Pipeline.lambda$execute$5(Pipeline.java:302)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	... 2 more

Issues Resolved

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@graytaylor0
Revert "Otel metrics source http service (opensearch-project#6604)"
213e4fa 
Signed-off-by: Taylor Gray <tylgry@amazon.com>
This reverts commit bb61dbe.
@github-actions

github-actions Bot commented Mar 19, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ License Header Violations Found

The following newly added files are missing required license headers:

  • data-prepper-plugins/otel-metrics-source/src/main/java/org/opensearch/dataprepper/plugins/source/otelmetrics/ConvertConfiguration.java
  • data-prepper-plugins/otel-metrics-source/src/test/java/org/opensearch/dataprepper/plugins/source/otelmetrics/OTelMetricsSourceTest.java

Please add the appropriate license header to each file and push your changes.

See the license header requirements: https://github.com/opensearch-project/data-prepper/blob/main/CONTRIBUTING.md#license-headers

@graytaylor0 graytaylor0 merged commit cb55f53 into opensearch-project:main Mar 19, 2026
70 of 72 checks passed
@TomasLongo

TomasLongo commented May 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@graytaylor0 Any further info on how and under what circumstances the error occurs?

Looking at the stacktrace, I supsect it somehow crashes while trying to intialize authorization. However, I wasn't able to reproduce the error.

Any help would be much appreciated.

Cheers, Tomas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@divbok divbok divbok approved these changes

@sb2k16 sb2k16 sb2k16 approved these changes

@engechas engechas Awaiting requested review from engechas

@san81 san81 Awaiting requested review from san81 san81 is a code owner

@srikanthjg srikanthjg Awaiting requested review from srikanthjg srikanthjg is a code owner

@dinujoh dinujoh Awaiting requested review from dinujoh dinujoh is a code owner

@kkondaka kkondaka Awaiting requested review from kkondaka kkondaka is a code owner

@KarstenSchnitter KarstenSchnitter Awaiting requested review from KarstenSchnitter KarstenSchnitter is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

@oeyh oeyh Awaiting requested review from oeyh oeyh is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@graytaylor0 @TomasLongo @divbok @sb2k16